search

Azure-Samples / active-directory-aspnetcore-webapp-openidconnect-v2

An ASP.NET Core Web App which lets sign-in users (including in your org, many orgs, orgs + personal accounts, sovereign clouds) and call Web APIs (including Microsoft Graph)
MIT License
1.38k stars 992 forks source link

Can you update the sample to dotnet core 3.1? 2.2 is no longer supported. #342

Closed kevin-jing closed 3 years ago

kevin-jing commented 4 years ago

Please provide us with the following information:

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

The issue was found for the following scenario:

Please add an 'x' for the scenario(s) where you found an issue

  1. Web app that signs in users
    1. [ ] with a work and school account in your organization: 1-WebApp-OIDC/1-1-MyOrg
    2. [ ] with any work and school account: /1-WebApp-OIDC/1-2-AnyOrg
    3. [ ] with any work or school account or Microsoft personal account: 1-WebApp-OIDC/1-3-AnyOrgOrPersonal
    4. [ ] with users in National or sovereign clouds 1-WebApp-OIDC/1-4-Sovereign
    5. [ ] with B2C users 1-WebApp-OIDC/1-5-B2C
  2. Web app that calls Microsoft Graph
    1. [ ] Calling graph with the Microsoft Graph SDK: 2-WebApp-graph-user/2-1-Call-MSGraph
    2. [ ] With specific token caches: 2-WebApp-graph-user/2-2-TokenCache
    3. [ ] Calling Microsoft Graph in national clouds: 2-WebApp-graph-user/2-4-Sovereign-Call-MSGraph
  3. [ ] Web app calling several APIs 3-WebApp-multi-APIs
  4. [ ] Web app calling your own Web API 4-WebApp-your-API
  5. Web app restricting users
    1. [ ] by Roles: 5-WebApp-AuthZ/5-1-Roles
    2. [ ] by Groups: 5-WebApp-AuthZ/5-2-Groups
  6. [ ] Deployment to Azure
  7. [ ] Other (please describe)

Repro-ing the issue

Repro steps

Expected behavior

Actual behavior

Possible Solution

Additional context/ Error codes / Screenshots

Any log messages given by the failure

Add any other context about the problem here, such as logs.

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

Versions

of ASP.NET Core, of MSAL.NET

Attempting to troubleshooting yourself:

Mention any other details that might be useful

Thanks! We'll be in touch soon.

jmprieur commented 4 years ago

@kevin-jing. I'm confused. which branch do you use? this sample is, to my knowledge, only .NET Core 3.1 ?

kevin-jing commented 4 years ago

@jmprieur I see "ASP.NET Core 2.2" here: https://docs.microsoft.com/en-us/azure/active-directory/develop/sample-v2-code#web-applications

kevin-jing commented 4 years ago

@jmprieur Another one is https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-v2-aspnet-core-webapp. The file I downloaded is "active-directory-aspnetcore-webapp-openidconnect-v2-aspnetcore2-2.zip". So, it's 2.2.

jmprieur commented 4 years ago

Oh. Thanks @kevin-jing. this is the quickstart We need to fix it.

jmprieur commented 4 years ago

I fixed the label in the sample page (the samples were really 3.1)

ghost commented 4 years ago

No, he is correct, at the link mentioned : first sample download on the page. https://github.com/Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2/archive/aspnetcore2-2.zip

However, I notice it targets 2.1 which is LTS

netcoreapp2.1

Thanks From: Jean-Marc Prieur notifications@github.com Sent: 04 May 2020 10:55 To: Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2 active-directory-aspnetcore-webapp-openidconnect-v2@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2] Can you update the sample to dotnet core 3.1? 2.2 is no longer supported. (#342)

I fixed the label in the sample page (the samples were really 3.1)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2/issues/342#issuecomment-623369467, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGMPVZAOSRL7SZ6M7GTCYXTRP2GGFANCNFSM4MXVBZJQ.

jmprieur commented 4 years ago

@dxm38 : which page are you talking about? https://docs.microsoft.com/en-us/azure/active-directory/develop/sample-v2-code ?

ghost commented 4 years ago

Hi,

The page that the person mentioned previously https://docs.microsoft.com/en-us/azure/active-directory/develop/quickstart-v2-aspnet-core-webapp

At download the code sample: contains the attached link https://github.com/Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2/archive/aspnetcore2-2.zip

which mentions asp.net core 2.2

However, as I stated, it appears to be targeting 2.1 so could be left at it is part of the LTS. I only mentioned it because the request was to update samples to 3.1.

If you feel I am mistaken please just ignore this as I just mentioned it for completeness. I am fine with the sample the way it is.

Best Wishes

From: Jean-Marc Prieur notifications@github.com Sent: 04 May 2020 12:02 To: Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2 active-directory-aspnetcore-webapp-openidconnect-v2@noreply.github.com Cc: dxm38 djm38@msn.com; Mention mention@noreply.github.com Subject: Re: [Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2] Can you update the sample to dotnet core 3.1? 2.2 is no longer supported. (#342)

@dxm38https://github.com/dxm38 : which page are you talking about? https://docs.microsoft.com/en-us/azure/active-directory/develop/sample-v2-code ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2/issues/342#issuecomment-623398430, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGMPVZGLEERS7Z64EYVH6XLRP2OC5ANCNFSM4MXVBZJQ.

jmprieur commented 4 years ago

Thanks for confirming @dxm38 We'll update the quickstart with Microsoft.Identity.Web (https://github.com/AzureAD/microsoft-identity-web/issues/126)

jmprieur commented 3 years ago

This was done.