Azure-Samples / active-directory-aspnetcore-webapp-openidconnect-v2

An ASP.NET Core Web App which lets sign-in users (including in your org, many orgs, orgs + personal accounts, sovereign clouds) and call Web APIs (including Microsoft Graph)

MIT License

1.38k stars 992 forks source link

Remove IDs use placeholders #769

Open kengaderdus opened 5 months ago

kengaderdus commented 5 months ago

Remove IDs use placeholders

We're replacing all real GUIDs with visibly fakes ones or placeholders or replacing existing placeholders with easy to read ones

[ ] You've read the Contributor Guide and Code of Conduct.
[ ] You've included unit or integration tests for your change, where applicable.
[ ] You've included inline docs for your change, where applicable.
[ ] There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

jennyf19 commented 4 months ago

thanks @kengaderdus but I don't see the value in this one...a lot of the previous content was more specific and actionable.

kengaderdus commented 4 months ago

@jennyf19

We're removing real GUIDs and replacing them with placeholders or visibly fake GUIDs.

kengaderdus commented 3 months ago

@jmprieur I still don't understand your request. Can you point me to text that you think should have been updated?

jmprieur commented 3 months ago

@kengaderdus: all chapters have app creation scripts that provide an app registration and the config of the app. See https://github.com/Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2/blob/master/1-WebApp-OIDC/1-1-MyOrg/AppCreationScripts/Configure.ps1 for instance.

For the B2C sample, not sure if we can accept this as setting-up B2C is a lot of work for customers.