Azure-Samples / active-directory-b2c-custom-policy-starterpack

Azure AD B2C now allows uploading of a Custom Policy which allows full control and customization of the Identity Experience Framework
http://aka.ms/aadb2ccustom
MIT License
340 stars 394 forks source link

SignUpSignIn does not render correctly for Email operatingMode #75

Open uioporqwerty opened 4 years ago

uioporqwerty commented 4 years ago

In my TrustFrameworkExtensions I added the following:

<ContentDefinition Id="api.signuporsignin">
        <LoadUri>https://{Settings:BlobStorageAccount}.blob.core.windows.net/{Settings:BlobContainer}/html/sign_in.html</LoadUri>
        <RecoveryUri>~/common/default_page_error.html</RecoveryUri>
        <DataUri>urn:com:microsoft:aad:b2c:elements:contract:unifiedssp:2.1.0</DataUri>
        <Metadata>
          <Item Key="DisplayName">Signin and Signup</Item>
        </Metadata>
      </ContentDefinition>

However, with version 2.1.0 the sign in name field is not an Email Address field. Based on the TrustFrameworkBase I would expect the behavior to have Email Address as the placeholder and label and to validate the input as a valid email address. The actual behavior is that the placeholder/label says "Sign In Name" and there is no email address validation. The input is also always throwing a format mismatch for whatever text is entered into that field. Perhaps the TrustFrameworkBase is out of date for this new version?

dkrasnove commented 3 years ago

@uioporqwerty Also having this issue after upgrading from 1.2.0 -> 2.1.0. Did you ever get this resolved? If not, I'm thinking I can override the default text with a LocalizedString element but I feel like there should be a better way...

e.g:

<LocalizedResources Id="api.signuporsignin.en">
    <LocalizedStrings>
        <LocalizedString ElementType="ClaimType" ElementId="signInName" StringId="DisplayName">Email Address</LocalizedString>
    </LocalizedStrings>
</LocalizedResources>
davidspiess commented 3 years ago

Problem still persists in 2.1.5