search

Azure-Samples / active-directory-dotnet-webapp-openidconnect

A .NET MVC web application that uses OpenID Connect to sign-in users from a single Azure Active Directory tenant.
159 stars 109 forks source link

Adding validation to config settings to clarify correct values #30

Closed kevinhillinger closed 6 years ago

kevinhillinger commented 7 years ago

Validation is now in place for what's set in the app settings to give immediate feedback to person using sample for themselves.

Also removed "PostLogoutRedirectUri and used a base app uri instead to remove confusion for what's the postlogout uri and the redirect uri. Now they are both set to the same value. Found almost every time that the consumer of the sample was confused what they should set for the Uri.

kevinhillinger commented 7 years ago

@skwan I think this pull request will be helpful.

dabe5 commented 7 years ago

Railway station and the power and influence over time and money 💵

dabe5 commented 7 years ago

Howrah station

dabe5 commented 7 years ago

Today for sure that your writing skill

dabe5 commented 7 years ago

This week off to you too 😊

kalyankrishna1 commented 6 years ago

Thanks for you input. We'll take in the suggestion to rename "PostLogoutRedirectUri". AuthConfig is a really nice implementation for robust config management, and should definitely be used in production apps, but we keep the code in samples as simple as possible to address the largest possible spectrum of developers.