search

Azure-Samples / aisearch-openai-rag-audio

A simple example implementation of the VoiceRAG pattern to power interactive voice generative AI experiences using RAG with Azure AI Search and Azure OpenAI's gpt-4o-realtime-preview model.
https://azure.microsoft.com/products/search
MIT License
211 stars 105 forks source link

Update devcontainer.json #18

Closed DarrenTurchiarelli closed 1 week ago

DarrenTurchiarelli commented 2 weeks ago

Add powershell as a feature within the container which saves end users a few clicks and having to rebuild the container

chuwik commented 1 week ago

You can run ./start.sh in the container, is powershell required for any other operation rather than if you want to run ./start.ps1? Seems like it'd be better to keep the dev container leaner.

DarrenTurchiarelli commented 1 week ago

As you stated, ./start.sh works but i was looking to cover step 4 in the read me which calls out the below:

Run this command to start the app: Windows: cd app pwsh .\start.ps1

The alternative is I can add a line into the readme on step 4.

chuwik commented 1 week ago

The dev container runs on linux, so you'd always use start.sh with it. I think you'd only have to use the ps1 script if you're running it on your windows machine directly.

chuwik commented 1 week ago

Closing PR, but happy to continue conversation if I'm missing something!