Add ApplicationSet to deploy AKS Cluster with Helm Chart - Githubissues

Azure-Samples / aks-platform-engineering

MIT License

66 stars 16 forks source link

Add ApplicationSet to deploy AKS Cluster with Helm Chart #56

Closed Jont828 closed 3 months ago

Jont828 commented 3 months ago

Purpose

...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

...

Other Information

dtzar commented 3 months ago

Ideally, would be good to also update root README so that people know if they want to deploy CAPZ AND have a cluster with SSH key provided (so that YAML template is truly idempotent) they will need to fill out this variable. You could link to this article: https://learn.microsoft.com/en-us/azure/virtual-machines/linux/create-ssh-keys-detailed#generate-keys-with-ssh-keygen