Azure-Samples / aks-platform-engineering

MIT License
65 stars 16 forks source link

Use of Azure Verified Modules #93

Open rick-pb opened 3 weeks ago

rick-pb commented 3 weeks ago

Please provide us with the following information:

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [x] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

n/a

Any log messages given by the failure

n/a

Expected/desired behavior

use of Azure Verified Modules in the Terraform IaC

OS and Version?

n/a

Versions

n/a

Mention any other details that might be useful

I would have expected the Terraform code here to utilize the Azure Verified Modules to help wth alignment to CAF, consistency with other microsoft initiatives etc. Was there any reason these were not adopted, and if not, can we expect these to be referenced in future?


Thanks! We'll be in touch soon.

dtzar commented 3 weeks ago

This repo is using Azure/terraform-azurerm-aks see code reference that is referenced in the "terraform verified modules" directory. It seems there is only this one avm-ptn-aks-production 0.1.0 module from April release. FWIW, @nellyk and @zioproto are the ones who created that module, and they also created this.

This repo wants to align where the long-term official support resides for production Terraform AKS module.

rick-pb commented 2 weeks ago

you could be using Azure Verified modules (AVM) for resources like your user assigned identity could use the following module.

dtzar commented 2 weeks ago

Makes sense - PRs welcome.