upgrade sk,others to latest version - Githubissues

Azure-Samples / aks-store-demo

Sample microservices app for AKS demos, tutorials, and experiments

MIT License

143 stars 225 forks source link

upgrade sk,others to latest version #86

Closed mosabami closed 8 months ago

mosabami commented 9 months ago

Purpose

Upgrade SK and other packages in the ai-service to latest version and made code modifications required to make it work

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ X] Other... Please describe: package upgrade

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

...

Other Information

pauldotyu commented 8 months ago

Overall LTGM. I did need to make a small change to init AzureChatCompletion for AAD auth. Also noticed the ai-service needs more memory now so bumped its limit to 85MB in ai-service.yaml files. This also requires changes in our docs so will merge this change after https://github.com/MicrosoftDocs/azure-docs-pr/pull/262737 has been merged.