search

Azure-Samples / azure-batch-samples

Azure Batch and HPC Code Samples
Other
260 stars 487 forks source link

Update Python samples to use azure-batch 1.0.0 #178

Closed alfpark closed 8 years ago

alfpark commented 8 years ago
alfpark commented 8 years ago

@annatisch - please take a look when you get a chance.

annatisch commented 8 years ago

@alfpark LGTM I've also run through all the samples with 1.0 with no trouble. Though it's worth noting that now one of the SDK runtime dependencies also uses crypto...

mmacy commented 8 years ago

@annatisch I believe the crypto requirement will break the Python tutorial on Ubuntu, correct? Should we add the crypto requirements now or in another PR?

https://github.com/Azure/azure-batch-samples/blob/master/Python/Batch/article_samples/python_tutorial_client.py#L262

annatisch commented 8 years ago

@mmacy, The article sample should be fine as it only installs azure-storage (not azure-batch) on the node, which to my knowledge doesn't install the SDK runtime msrest. As long as we stick to 0.32 it should be okay.

mmacy commented 8 years ago

@annatisch OK cool, thanks. Also just noticed it forces 030 there, so we should be safe. I'll verify after merge to be sure.

alfpark commented 8 years ago

@annatisch should I go ahead and set storage to 0.33.0 then? If we're installing crypto, then we should just go ahead and put the latest version on as well due to the bug fixes.

annatisch commented 8 years ago

If we were to go to 0.33 we would need to make additional changes to the samples. Pool start-up script would need to be supplemented with something like: sudo apt-get install build-essential libssl-dev libffi-dev python-dev

alfpark commented 8 years ago

@annatisch At least for the main samples (not the article samples), the python batch package isn't needed on the pools.

annatisch commented 8 years ago

@alfpark then it should be fine. The article sample explicitly references storage version 0.30, so should be protected from changes we make to the requirements.txt