Azure-Samples / azure-cache-redis-samples

This repository contains samples that demonstrate best practices and general recommendations to communicate with Azure Redis Cache Service caches from various Redis client frameworks.
MIT License
69 stars 156 forks source link

fxl---recommended change from Python #28

Closed flang-msft closed 1 year ago

flang-msft commented 1 year ago

When we updated the docs for this, we got this recommendation from one of the Python developers.

Purpose

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

flang-msft commented 1 year ago

[X ] Bugfix [ ] Feature [ X] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ X] Documentation content changes [ ] Other... Please describe:

A freshness pass was needed to update the docs to the current working version of Python. We made those edits that lead to the need to update the sample files in this repo.

flang-msft commented 1 year ago

@brendanzagaeski - can you merge this one?

flang-msft commented 1 year ago

@brendanzagaeski, @stanleysmall-microsoft - I had not transferred the doc changes to the readme file. I think this is good to go.

This is the PR for the docs - https://github.com/MicrosoftDocs/azure-docs-pr/pull/221333#event-8641150407

flang-msft commented 1 year ago

@brendanzagaeski - I think if you approve this, it can be merged automatically?

flang-msft commented 1 year ago

@stanleysmall-microsoft - Thanks Stanley for the merge. Sorry, next time I'll put in the in the reviewers.

flang-msft commented 1 year ago

@philon-msft - this PR was approved. Can you please merge it?

flang-msft commented 1 year ago

@philon-msft - Yahooo! Thanks!!!