Azure-Samples / azure-cache-redis-samples

This repository contains samples that demonstrate best practices and general recommendations to communicate with Azure Redis Cache Service caches from various Redis client frameworks.
MIT License
69 stars 156 forks source link

Support Microsoft Entra ID with Redisson client library #48

Closed backwind1233 closed 9 months ago

backwind1233 commented 10 months ago

Context

Refer to https://github.com/MicrosoftDocs/azure-docs-pr/pull/260292#discussion_r1445151576, make MSI auth the default/recommended option

Purpose

Support Microsoft Entra ID with Redisson client library.

Pull Request Type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Other Information

edburns commented 10 months ago

Seeking review and merge from @philon-msft .

This change was requested by Shruti Pathak and approved by myself.

edburns commented 9 months ago

Hello @philon-msft . As far as I know, @backwind1233 and I have addressed all outstanding concerns.

edburns commented 9 months ago

Hello @philon-msft ,

@backwind1233 and I went through the remaining issues and marked them Resolved based on his confirmation that the issues were addressed.

If you agree that the issues are all resolved, please do merge this PR. If not, please help me understand what we missed.

Thanks,

Ed