Azure-Samples / azure-digital-twins-unreal-integration

Sample project demonstrating the Unreal Engine plug-in for Azure Digital Twins
https://www.unrealengine.com/marketplace/en-US/product/adtlink-for-unreal-engine
MIT License
92 stars 43 forks source link

fix ms graph migration breaking changes #14

Closed jaredholloway94 closed 1 year ago

jaredholloway94 commented 2 years ago

Purpose

Fix /deployment/scripts/deploy.ps1 to comply with the new Microsoft Graph version of the Azure CLI.

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid

Other Information

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

kofiasare266 commented 1 year ago

Hi Jared,

I attempted a new deployment with your pull request but that failed. I am not too sure what is happening. Kindly help. Screenshot 2022-09-01 171248

nkronqvist commented 1 year ago

Also got error when trying the patch. See attached log from install and the error details from Azure failed Deployment. Using a Free Trial of Azure. Any clue what might be the issue?

deployment_error.txt deployment_error_azure.txt

kofiasare266 commented 1 year ago

Also got error when trying the patch. See attached log from install and the error details from Azure failed Deployment. Using a Free Trial of Azure. Any clue what might be the issue?

deployment_error.txt deployment_error_azure.txt

Hi Nils, the plugin is broken. I am told it is being fixed. So fingers crossed.

digitaltriplets commented 1 year ago

Also got error when trying the patch. See attached log from install and the error details from Azure failed Deployment. Using a Free Trial of Azure. Any clue what might be the issue? deployment_error.txt deployment_error_azure.txt

Hi Nils, the plugin is broken. I am told it is being fixed. So fingers crossed.

Hi everyone,

Is there any update on this issue?

also if someone could respond with examples of what repo-adress, repo-name and branch-name should look like (be replaced with) so i know what i should be looking for.

many thanks, DT

vararth commented 1 year ago

I urgently need an update to this.. also facing the same issue

adamlash commented 1 year ago

Great changes! Apologies for the lack of movement on this repo, I am in the process of taking care of this repository.

I am running through a quick check to solve some of the issues on this repo, and this solves a few of them. I will reply to the relevant issues located in the larger repo once an end-end deployment has been confirmed.

Merging these changes in.

adamlash commented 1 year ago

Hello All on this PR,

I have recently made some more changes in a newer PR fixing up a few bugs and issues related to this repo. Feel free to try this again and see if you get the expected outputs.

Any issues? Feel free to open an issue and I'll get to it ASAP

niagara1120 commented 1 year ago

image Oops....I just tried it ! There is still an error