Azure-Samples / azure-digital-twins-unreal-integration

Sample project demonstrating the Unreal Engine plug-in for Azure Digital Twins
https://www.unrealengine.com/marketplace/en-US/product/adtlink-for-unreal-engine
MIT License
92 stars 43 forks source link

Step 3 - app run/build error #5

Closed RobMDoe closed 2 years ago

RobMDoe commented 2 years ago

Please provide us with the following information:

This issue is for a: (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Problems with Step 3 'Simulate Devices'. Have used GIT in Windows CLI to clone 'mock-devices' and 'azure-digital-twins-unreal-integration' to my root folder C:\users\rober. Have copied hvac.ts, index.ts, smartbinary.ts files between as instructed. Changed path to src/client (incidentally, the copied code attaches client to npm), then > npm ci && npm run build. The app doesn't build.

Any log messages given by the failure

Attached below.

Expected/desired behavior

Run/build app

OS and Version?

Windows 11 Pro

Versions

21H2

Mention any other details that might be useful

Otherwise all fine up to this stage of Step 3.


Thanks! We'll be in touch soon.

2022-02-04T23_36_02_363Z-debug - Copy.log

AshokPeddakotla-MSFT commented 2 years ago

@stevebus Steve Busby FTE @SamWSP @3DStephen @marvin-garcia could you please help address this issue. Related to : https://docs.microsoft.com/en-us/answers/questions/724488/index.html

stevebus commented 2 years ago

@adamlash will own this project now from the MSFT side and check into this.

adamlash commented 2 years ago

Hey @RobMDoe ,

It looks like the root of this issue is to do with a Dependency on the Simulator node-sass which uses the node-gyp package to compile various parts of the Simulator. It is expecting Python2.7 and VS 2017 C++ Tools to be installed and available somewhere on the path (or in the directories eg C:/Python27 or the VS default install dir)

As a workaround for now, the following should suffice:

Re-run the command npm ci && npm run build

Let me know if this functions for you! I replicated this on a Virtual Machine and these were the steps required. I'll close off this issue in 2 weeks If I don't hear back.

Future fixes should remove the simulators dependency on node-sass as this has now been deprecated per: https://www.npmjs.com/package/node-sass. Will look into Simulators' build and consider if a PR is required to remove this deprecated dependency.

RobMDoe commented 2 years ago

Hi @adamlash . Thanks for your quick response. Python27 and VS 2017 Build Tools installed and now all running perfectly.

stevebus commented 2 years ago

@RobMDoe - thanks for reporting the issue and let us know if you have any other problems!

@adamlash - thanks for the research and the fix!