search

Azure-Samples / azure-django-postgres-flexible-aca

Web app using Python Django backend, set up for deployment to Azure Container Apps with Azure PostgreSQL Flexible Server.
MIT License
15 stars 31 forks source link

Safer key vault name #30

Closed pamelafox closed 1 year ago

pamelafox commented 1 year ago

Purpose

Remove hyphens from KeyVault name since it freaks out if there are multiple dashes in a row. 

VaultNameNotValid: The vault name 'django-azure-aca--vault' is invalid. A vault's name must be between 3-24 alphanumeric characters. The name must begin with a letter, end with a letter or digit, and not contain consecutive hyphens. Follow this link for more information: https://go.microsoft.com/fwlink/?linkid=2147742

Another approach is to replace '--' with '-' after creating the name, but this is simpler.

Does this introduce a breaking change?

[ ] Yes
[X] No (unless you have an existing deploy!)

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

azd up

pamelafox commented 1 year ago

@kjaymiller As promised