search

Azure-Samples / azure-django-postgres-flexible-aca

Web app using Python Django backend, set up for deployment to Azure Container Apps with Azure PostgreSQL Flexible Server.
MIT License
15 stars 31 forks source link

Lab edits #36

Closed pamelafox closed 1 year ago

pamelafox commented 1 year ago

Purpose

A variety of edits after I went through lab in Codespaces. The good: azd up was way faster this time, 10 mins end to end The bad: I cant run azd pipeline config in Codespaces for my MS account, I believe this is a known issue with Microsoft's policy on GitHub logins.

The biggest change I made was removing azd init. As far as I can tell, that command is only needed if you're trying to create a new template from scratch or if you're trying to download a template. I find it confusing to use in an exiting azd-ified codebase, so I only used azd up and that worked out well. We can double check that with Savannah if we're not sure.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

Other Information

pamelafox commented 1 year ago

@kjaymiller Review after doing it in Codespaces.

kjaymiller commented 1 year ago

The bad: I cant run azd pipeline config in Codespaces for my MS account, I believe this is a known issue with Microsoft's policy on GitHub logins.

Okay we were running into this issue. Confusingly it recently started happening. I think for now we just remove the pipeline config.