Azure-Samples / azure-django-postgres-flexible-aca

Web app using Python Django backend, set up for deployment to Azure Container Apps with Azure PostgreSQL Flexible Server.
MIT License
15 stars 31 forks source link

Upgrade ACA #41

Closed pamelafox closed 1 year ago

pamelafox commented 1 year ago

Purpose

This PR updates the azd-related files to work with the latest version, 0.9, which changed container app process significantly. The primary changes are in: azure-dev.yaml, azure.yaml, main.bicep, main.parameters.json, web.bicep. The other changes are just new files from core/.

One big change is that we no longer need to fetch the secrets from key vault, we can fetch them directly from the container app. We still use keyvault to store the secrets so that we can reuse the same secrets on each azd deploy, however.

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

pamelafox commented 1 year ago

@kjaymiller PR for when you're available.

kjaymiller commented 1 year ago

Looks good... I think there is an issue with the Format Check Action so I'll go ahead and merge