Azure-Samples / azure-files-samples

This repository contains supporting code (PowerShell modules/scripts, ARM templates, etc.) for deploying, configuring, and using Azure Files.
https://docs.microsoft.com/azure/storage/files/storage-files-introduction
MIT License
233 stars 195 forks source link

Bugfix/fix null reference exceptions #135

Open alansingfield opened 1 year ago

alansingfield commented 1 year ago

This is what I needed to do to get the script to run reliably on Server 2019, Powershell 7.3.1

In Debug-KerberosTicketEncryption - if $kerberosTicketEncryptionClient is an array with 1 element, the condition then goes on to try to read the .Value property, which is $null. Then .ToString() on this gives a null reference. I added a check to cope with this.

The check for EncryptionCiphers (Get-SmbServerConfiguration).PSobject.Properties.Name -contains "EncryptionCiphers" was missing an outer set of brackets which stopped it from detecting that this property was missing on down-level servers.

There were a number of calls to the .Value property of the SID - this is a string already so we get $null rather than the desired value - causing null reference exceptions.

The Set-ADAccountPassword cmdlet takes a string DN in the -Identity property, not an object.