Azure-Samples / azure-files-samples

This repository contains supporting code (PowerShell modules/scripts, ARM templates, etc.) for deploying, configuring, and using Azure Files.
https://docs.microsoft.com/azure/storage/files/storage-files-introduction
MIT License
226 stars 192 forks source link

Do verbose logging only when instructed. #154

Closed sprasad-microsoft closed 9 months ago

sprasad-microsoft commented 1 year ago

Right now we enable cifsFYI logs unconditionally when capturing diagnostics. But this makes changes to debugfs, which will not be possible with kernel lockdown enabled, and that is the default with trusted VMs which are becoming more common.

Additionally, we do not use verbose logs much for our debugging. We have grown to use trace-cmd more.

This change disables verbose logging by default.

No need to document this. It will complicate the instructions for the customers. Instruct customers specially when verbose logs are needed.