Azure-Samples / azure-sdk-for-go-samples

Examples of how to utilize Azure services from Go.
MIT License
296 stars 184 forks source link

Use the recommended method WaitForCompletionRef #236

Closed tariq1890 closed 5 years ago

tariq1890 commented 5 years ago

As per this godoc

// WaitForCompletion will return when one of the following conditions is met: the long
// running operation has completed, the provided context is cancelled, or the client's
// polling duration has been exceeded.  It will retry failed polling attempts based on
// the retry value defined in the client up to the maximum retry attempts.
// Deprecated: Please use WaitForCompletionRef() instead.
func (f Future) WaitForCompletion(ctx context.Context, client autorest.Client) error {
    return f.WaitForCompletionRef(ctx, client)
}

This should be a safe change

vladbarosan commented 5 years ago

@tariq1890 yes this is a safe change. thanks