search

Azure-Samples / azure-sdk-for-go-samples

Examples of how to utilize Azure services from Go.
MIT License
296 stars 184 forks source link

Enables live-tests on Azure-Pipeline for keyvault #273

Closed JerryPei1997 closed 4 years ago

JerryPei1997 commented 4 years ago

It's not safe to using .env file. So change to use enviroment variables on local and use secret variables on pipelines to ensure the security of variables such as clientSecret, subscriptionID...

This PR uses KeyVault live test as an example to verify the feasibility of using environmental variables.

What this PR changed:

  1. add livetest.yml file and steps/live_test.yml for azure pipeline live test
  2. update azure-pipelines.yml
  3. update internal/config/env.go to use enviroment variables
  4. update the output messages in keyvault_test.go
ArcturusZhang commented 4 years ago

Basically LGTM, should be good to merge once you resolve these comments.