search

Azure-Samples / azure-sdk-for-go-samples

Examples of how to utilize Azure services from Go.
MIT License
297 stars 184 forks source link

initial change to keyvault tests . #282

Closed mayelms closed 4 years ago

mayelms commented 4 years ago

This initial PR is to change the existing : azure-sdk-for-go-samples/keyvault/keyvault_test.go to two files:

To make it similar to the tests in azure-sdk-for-go-samples/storage/ . This allows for a common setup() and teardown() for all tests in that folder, and to easily add new test cases.

I also added : azure-sdk-for-go-samples/keyvault/keyvaultsecrets_test.go to test the code in /keyvault/pass_manager.go.

ArcturusZhang commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago
Azure Pipelines successfully started running 1 pipeline(s).
ArcturusZhang commented 4 years ago

Hi @mayelms thanks for this PR!

While these changes look good to me, could you please resolve the CI failure? The CI is reporting that the generateName function is un-used, could you please remove this function?

mayelms commented 4 years ago

@ArcturusZhang : I have made the changes, please review. Thanks.