search

Azure-Samples / azure-sdk-for-go-samples

Examples of how to utilize Azure services from Go.
MIT License
297 stars 184 forks source link

add compute sample #299

Closed Alancere closed 3 years ago

Alancere commented 3 years ago

Thanks for your contribution! Please let us know what problems this PR addresses or what functionality it adds. Please link to other related issues and PRs to speed up review. Thank you!

nickzhums commented 3 years ago

did we include the readme file for docs pipeline to digest? eg. this file:

https://github.com/Azure-Samples/azure-samples-js-management/blob/main/samples/compute/README.md

we should have one readme per RP

jhendrixMSFT commented 3 years ago

Why is the track 1 sample being deleted?

nickzhums commented 3 years ago

Why is the track 1 sample being deleted?

it's mainly to keep a clean structure, also, it is still in github history and we can point to previous locations if needed

jhendrixMSFT commented 3 years ago

So we're going to keep track of all the previous commits so we can tell people where to look?

nickzhums commented 3 years ago

So we're going to keep track of all the previous commits so we can tell people where to look?

I don't think we need to keep track of every commit such as this, but we can provide some general directions on this landing page and guide users in case they are going to look for track 1 samples. The samples are still categorized based on each RP.

jhendrixMSFT commented 3 years ago

I get that we want to promote track 2, however this bifurcates the samples and starts promoting things that are still preview which is not going to be very clear to customers. How was this addressed in other languages?

nickzhums commented 3 years ago

I get that we want to promote track 2, however this bifurcates the samples and starts promoting things that are still preview which is not going to be very clear to customers. How was this addressed in other languages?

Just talking about management plane here, for Java, all samples are directly updated to Track 2, and previous Track 1 samples were given a tag in release (even in preview) Python, JavaScript don't have this problem as there was no samples repo at all, so all samples started with Track 2 in public preview.

jhendrixMSFT commented 3 years ago

Makes sense, and IMO we should be doing something similar. Can we create a track2 branch for all the track 2 samples? Once it has critical mass, we can rename it to main (and make it the default) and rename master to legacy (or tag it or whatever).

nickzhums commented 3 years ago

Makes sense, and IMO we should be doing something similar. Can we create a track2 branch for all the track 2 samples? Once it has critical mass, we can rename it to main (and make it the default) and rename master to legacy (or tag it or whatever).

i think that's a pretty reasonable suggestion. @ArcturusZhang @lirenhe thoughts on this?

ArcturusZhang commented 3 years ago

I will create a branch named new-version to put track 2 samples

ArcturusZhang commented 3 years ago

closing this PR since we are changing the base branch