Azure-Samples / azure-sdk-for-go-samples

Examples of how to utilize Azure services from Go.
MIT License
301 stars 184 forks source link

Clenup main #348

Closed tadelesh closed 2 years ago

tadelesh commented 2 years ago

Remove all track1 samples and refine docs

tadelesh commented 2 years ago

Do not merge now as the ci broke again.

tadelesh commented 2 years ago

/azp where

azure-pipelines[bot] commented 2 years ago
Azure DevOps orgs getting events for this repository:
tadelesh commented 2 years ago

/azp list

azure-pipelines[bot] commented 2 years ago
CI/CD Pipelines for this repository:
tadelesh commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 1 pipeline(s).
tadelesh commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 1 pipeline(s).
tadelesh commented 2 years ago

Not sure why we should delete track 1 samples. Is this topic discussed? @xboxeer

Like the SDK repo, I want to move the track1 samples to the legacy branch in order to expose only track2 samples for customer in main to avoid any legacy usage. But we could discuss it more. @xboxeer What do you think?

xboxeer commented 2 years ago

Do we know where these samples are referenced? only in API reference site?

tadelesh commented 2 years ago

Do we know where these samples are referenced? only in API reference site?

Some docs will directly refer to this repo: https://github.com/Azure-Samples/azure-sdk-for-go-samples. So, I think for main, we should not show track1 samples.

tadelesh commented 2 years ago

@xboxeer Do you have any further concern about the change?

tadelesh commented 2 years ago

@xboxeer Could you help to confirm the deprecation message used in go.mod and README.md. Deprecated: Please note, this package has been deprecated. Replacement can be found under github.com/Azure-Samples/azure-sdk-for-go-samples/tree/main/sdk. We strongly encourage you to upgrade to continue receiving updates. See Migration Guide for guidance on upgrading. Refer to our deprecation policy for more details.

lirenhe commented 2 years ago

@tadelesh, what is this build failure about?

tadelesh commented 2 years ago

@tadelesh, what is this build failure about?

Previous code lint problem. Let me fix them before merge.

tadelesh commented 2 years ago

/azp run

azure-pipelines[bot] commented 2 years ago
Azure Pipelines successfully started running 1 pipeline(s).