Net8 and platform specific fixes macos linux support

Azure-Samples / azure-search-dotnet-utilities

C# code samples that help with admin or development tasks in Azure Cognitive Search.

MIT License

18 stars 17 forks source link

Net8 and platform specific fixes macos linux support #18

Closed Glareone closed 2 months ago

Glareone commented 3 months ago

1) Changes to support Macos and Linux using Path.Combine 2) Migrated to .net-8. 3) AI Search version change to support modern indexes which is required by AI Seach nowadays. Comment left. 4) Little code improvements in several places 5) General code clean up. 6) got rid of IDFieldName property which is never used 7) updated the namespace name to make identical with projectname

Glareone commented 3 months ago

@microsoft-github-policy-service agree

Glareone commented 2 months ago

@HeidiSteen hello Heidi! May I ask you to review this little PR and accept changes?

PA I see a separate PR which delivers my changes with .Net version and minor platform-specific fixes using Path.Combine as well.

HeidiSteen commented 2 months ago

@Glareone Thanks for the contribution, this was very helpful!