search

Azure-Samples / azure-search-openai-demo-csharp

A sample app for the Retrieval-Augmented Generation pattern running in Azure, using Azure Cognitive Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences.
MIT License
555 stars 346 forks source link

Container app targetPort should default to 80, and have 8080 in app bicep files. #220

Closed jongio closed 8 months ago

jongio commented 8 months ago

The targetPort was changed to 8080 here:

https://github.com/Azure-Samples/azure-search-openai-demo-csharp/blob/fb1ca3248e693ea7acb04740c97526c5a49c82eb/infra/core/host/container-app.bicep#L71

Instead of changing /core, the targetPort should be updated in the application bicep.

This allows you to easily update to latest /core when needed.

jongio commented 8 months ago

Same here: https://github.com/Azure-Samples/azure-search-openai-demo-csharp/blob/main/infra/core/host/container-app-upsert.bicep#L67