search

Azure-Samples / azure-search-openai-demo-csharp

A sample app for the Retrieval-Augmented Generation pattern running in Azure, using Azure Cognitive Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences.
MIT License
555 stars 346 forks source link

Change main.parameters.json to main.bicepparam #224

Open jongio opened 8 months ago

jongio commented 8 months ago

Bicep now supports the much cleaner bicepparam files. Let's update this project to utilize that.

luisquintanilla commented 8 months ago

@jongio do we have examples of this we can use as reference?

LittleLittleCloud commented 8 months ago

I try to use VSCode to generate .bicepparam and the generated file has the following error

image

Also when I try initializing parameter value using readEnvironmentVariable, I get the following error. This is confusing because the AZURE_ENV_NAME is defined in .env, not on my local system. Do I need to update my environment on my local machine to contains all environment from .env? image

jongio commented 8 months ago

https://github.com/Azure-Samples/demystifying-rag-dotnet/blob/main/infra/main.bicepparam

luisquintanilla commented 6 months ago

@LittleLittleCloud we're okay to close this one right?

jongio commented 6 months ago

@LittleLittleCloud we're okay to close this one right?

Close as-in not do? It would be good to switch to bicepparam