azd up requires openAIApiKey infra param?

diberry commented 1 month ago

Please provide us with the following information:

This issue is for a: (mark with an `x`)

- [ X] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

azd auth login

azd up

@achandmsft

Any log messages given by the failure

@diberry ➜ /workspaces/azure-search-openai-demo-csharp (main) $ azd up
? Enter a new environment name: diberry-dotnet-chat
(✓) Done: Downloading Bicep
? Select an Azure Subscription to use: 23. Azure Dev Platform Services Content Team (2123cb08-23fa-4a80-afec-4ec9e015433f)
? Select an Azure location to use: 11. (US) East US 2 (eastus2)
? Enter a value for the 'openAIApiKey' infrastructure parameter: [? for help]

Expected/desired behavior

AZD up shouldn't ask for anything other than sub and locations.

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?) Codespaces

Versions

Mention any other details that might be useful

Thanks! We'll be in touch soon.

lgmorand commented 1 month ago

I do agree. it ask for it, while it deploys a new OpenAI endpoint

KristinBethea commented 1 month ago

Where do we get the openAIApiKey? It's not part of the demo instructions.

lgmorand commented 1 month ago

you can ignore it. the openakey is when you provide your own existing instance. but the azd up will pop up a 3.5gpt and a dedicated openai instance by default, even with the key

furthermore, it store the openAIkey in .azure but without the endpoint, nor the deployment name, to me, that's useless

jaliyaudagedara commented 3 weeks ago

Related: #295

FBoucher commented 3 weeks ago

It will use an existing OpenAI service with this key if provided. If let empty the provisioning will create an Azure openAI service and use that one.

Azure-Samples / azure-search-openai-demo-csharp