Azure-Samples / azure-search-openai-demo

A sample app for the Retrieval-Augmented Generation pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences.
https://azure.microsoft.com/products/search
MIT License
5.6k stars 3.75k forks source link

gpt-4o #1644

Closed mirojs closed 3 weeks ago

mirojs commented 1 month ago

Please provide us with the following information:

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [x] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

May I know how to deploy the new gpt-4o model? Should it be the same as with the gpt-4 model? Thanks.

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)

azd version?

run azd version and copy paste here.

Versions

Mention any other details that might be useful


Thanks! We'll be in touch soon.

mattgotteiner commented 1 month ago

@pamelafox is working on this. It did require other changes AFAIK

data-analytics-copilot commented 1 month ago

Is there a plan to include the option for video and voice input as part this core app utilizing gpt4o multi input once available?

mirojs commented 1 month ago

@mattgotteiner That's good news, thanks.

Estrogenetics commented 1 month ago

@pamelafox is working on this. It did require other changes AFAIK

This is correct, I got it to work by deleting gpt-4 turbo chat and then deploying gpt-4o from the Azure Openai service interface after the model was made generally available at Microsoft Build. Deploying with azd up caused the web interface to fail loading after changing the model from gpt-4 to gpt-4o. Nice work around though and really loving the improvements of gpt-4o so far! Was such an exciting announcement!

pamelafox commented 1 month ago

Are you all trying to use gpt-4o for the vision feature, or for just non-image answers? The configuration would be different depending.

mirojs commented 1 month ago

Right. Ideally, the vision feature is preferred. If there would be too much effort, a temporary replacement for Turbo would also work due to the language processing capability difference.

On Tue, 28 May 2567 BE at 21:55 Pamela Fox @.***> wrote:

Are you all trying to use gpt-4o for the vision feature, or for just non-image answers? The configuration would be different depending.

— Reply to this email directly, view it on GitHub https://github.com/Azure-Samples/azure-search-openai-demo/issues/1644#issuecomment-2135437773, or unsubscribe https://github.com/notifications/unsubscribe-auth/A37NCH3WRLHI6YKV7TL6I23ZESLELAVCNFSM6AAAAABIDYXSC6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZVGQZTONZXGM . You are receiving this because you authored the thread.Message ID: @.***>

pamelafox commented 1 month ago

Okay, I'm going to test it out with the vision feature today. I did actually test the repo already with the OpenAi.com gpt-4o (and saw good performance improvements), but I'm going to test it with an Azure OpenAI deployment now that those are available.

pamelafox commented 1 month ago

You can see gpt-4o related changes in this branch: https://github.com/Azure-Samples/azure-search-openai-demo/pull/1656/files

I'll continue doing performance and quality testing over next few days. Unfortunately, as mentioned in the PR, its annoyingly difficult to simply swap to a gpt-4o deployment due to the region differences.

For an existing deployment:

Then it should create a new OpenAI resource in that location with the gpt-4o deployment.

Lawndemon commented 1 month ago

@pamelafox is working on this. It did require other changes AFAIK

This is correct, I got it to work by deleting gpt-4 turbo chat and then deploying gpt-4o from the Azure Openai service interface after the model was made generally available at Microsoft Build. Deploying with azd up caused the web interface to fail loading after changing the model from gpt-4 to gpt-4o. Nice work around though and really loving the improvements of gpt-4o so far! Was such an exciting announcement!

how did you get the web interface working again? I'm running into the same problem so any advice would be appreciated!

pamelafox commented 1 month ago

What error are you getting with the web interface?

Lawndemon commented 3 weeks ago

What error are you getting with the web interface?

I was getting the blank site with no errors during build + deploy. Did a bit of digging and found some version mismatches in requirements. txt as well as a couple other spots that needed to be updated in main.bicep as well as some tweaks required in modelhelper.py and config.py. I managed to track down the errors by tuning the app insights implementation and it showed the app service wasn't starting properly. Working great with GPT4o now though!

pamelafox commented 3 weeks ago

@Lawndemon Ah yes if you still have modelhelper.py from the older version of the repo, that would need tweaks. The repo now uses a packaged version of modelhelper that I specifically upgraded for gpt-4o compatibility.

Closing this issue since the repo now defaults to gpt-4o for vision.