Closed john0isaac closed 3 weeks ago
Thank you! Code looks good from a first glance, I'll check out the branch myself locally and see if I notice anything while using it.
I tried to make the naming match your AzureSpeechOutput
in case you want to merge it in one file and do the checks there.
IMHO, the way it is now is cleaner and easy to customize as the features doesn't overlap.
Weird, I did run pre-commit run --all-files
.
I did fix the ruff things, it should be good now.
Purpose
This PR adds the optional feature to enable the built into browsers text to speech optional feature by setting the
USE_SPEECH_OUTPUT_BROWSER
boolean.Does this introduce a breaking change?
When developers merge from main and run the server, azd up, or azd deploy, will this produce an error? If you're not sure, try it out on an old environment.
Does this require changes to learn.microsoft.com docs?
This repository is referenced by this tutorial which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial, check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.
Type of change
Code quality checklist
See CONTRIBUTING.md for more details.
python -m pytest
).python -m pytest --cov
to verify 100% coverage of added linespython -m mypy
to check for type errorsruff
andblack
manually on my code.