Azure-Samples / azure-search-openai-demo

A sample app for the Retrieval-Augmented Generation pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences.
https://azure.microsoft.com/products/search
MIT License
5.57k stars 3.74k forks source link

UI developer settings fix #1688

Closed vedenev closed 2 weeks ago

vedenev commented 3 weeks ago

Purpose

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error? If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial, check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[x] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

THIS IS SMALL CHANGE IN THE FRONTEND CODE. I TESTED IT MANUALLY. IT WORKS.

vedenev commented 3 weeks ago

The bug description: What it does: When I enter a category name in this text box, that category is excluded from the search results, as it should be. When I reopen the settings menu, the text box is empty instead of displaying what I've entered in it. However, the category will keep being excluded in the following searches until I enter some other value there. What it should do: The category name I've entered should be displayed in the text box to indicate that the category is being excluded from search results.

pamelafox commented 2 weeks ago

@vedenev Can you agree to the CLA, per the GitHub comment above?

vedenev commented 2 weeks ago

@pamelafox @microsoft-github-policy-service agree [company="{Silo AI}"]

vedenev commented 2 weeks ago

@microsoft-github-policy-service agree company="Silo AI"