Azure-Samples / azure-search-openai-demo

A sample app for the Retrieval-Augmented Generation pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences.
https://azure.microsoft.com/products/search
MIT License
5.94k stars 4.08k forks source link

Replace storage accounts with AVM modules #1826

Open tonybaloney opened 2 months ago

tonybaloney commented 2 months ago

Purpose

Replaces AZD Core Storage account module with the AVM one.

tonybaloney commented 2 months ago
Deployment Error Details:
AccountPropertyCannotBeUpdated: The property 'isHnsEnabled' was specified in the input, but it cannot be updated as it is read-only. For more information, see - https://aka.ms/storageaccountupdate

I think this is because AZD core hard-coded the HNS value to false whereas AVM uses null by default.

tonybaloney commented 2 months ago

Related to https://github.com/Azure/azure-rest-api-specs/issues/18441

tonybaloney commented 2 months ago

AVM tracking issue https://github.com/Azure/bicep-registry-modules/issues/1522

We can't make this migration until this is fixed. Anyone who has a storage account deployed already will get a failure.