Azure-Samples / azure-search-openai-javascript

A TypeScript sample app for the Retrieval Augmented Generation pattern running on Azure, using Azure AI Search for retrieval and Azure OpenAI and LangChain large language models (LLMs) to power ChatGPT-style and Q&A experiences.
MIT License
252 stars 130 forks source link

Upgrade repo to latest azd/infra/core #130

Closed jongio closed 8 months ago

jongio commented 1 year ago

This repo uses an old version of azd/infra/core. There have been many improvements and security updates since this version. Please upgrade to latest found here:

https://github.com/Azure/azure-dev/tree/main/templates/common/infra/bicep

Good example of swa: https://github.com/Azure/azure-dev/blob/main/templates/todo/projects/nodejs-mongo-swa-func/.repo/bicep/infra/main.bicep

Good example of aca: https://github.com/Azure/azure-dev/blob/main/templates/todo/projects/nodejs-mongo-aca/.repo/bicep/infra/main.bicep

sinedied commented 1 year ago

@jongio I updated all templates and added the required user assigned identity for the container apps in this branch: https://github.com/Azure-Samples/azure-search-openai-javascript/tree/infra-update

But when deploying I get this error:

image

Did I missed something? Thanks for your help

anfibiacreativa commented 11 months ago

@sinedied @jongio Any updates here?

jongio commented 10 months ago

Can you make sure you have the latest infra/core (it may have changed since your last sync).

Also, please compare your bicep with the bicep from the other azure-search-openai templates that use aca.

github-actions[bot] commented 8 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this issue will be closed.