Closed JasonHaley closed 8 months ago
@JasonHaley please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:
- (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
- (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
@microsoft-github-policy-service agree
It seems the Playwright tests are failing, could you check that it works for you? It may need an update with your fix.
# once
npm run install:playwright
npm run test:playwright
I'll take a look at it this afternoon and let you know.
@sinedied I think the problem was line 25 in OneShot.tsx needs to be:
const [approach, setApproach] = useState<Approaches>(Approaches.ReadRetrieveRead);
I ran the tests and that seems to fix most of them, but there are still 2 unrelated ones failing on my machine, which I'm guessing is some configuration on my system.
Thanks, that's perfect :)
This issue is for a: (mark with an
x
)Minimal steps to reproduce
The ask-read-retrieve-read is the approach that uses the Dynamic Tool.
You can try changing the approach in the Developer Settings, but it does not seem to work.
Also the OneShot.tsx file does have the rrr hard-coded.
Expected/desired behavior