Azure-Samples / azure-search-openai-javascript

A TypeScript sample app for the Retrieval Augmented Generation pattern running on Azure, using Azure AI Search for retrieval and Azure OpenAI and LangChain large language models (LLMs) to power ChatGPT-style and Q&A experiences.
MIT License
237 stars 121 forks source link

chore(infra): update to latest azd infra templates (closes #130) #190

Closed sinedied closed 6 months ago

sinedied commented 7 months ago

Purpose

App insights is now enabled by default, as part of the newer templates.

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[x] Other... Please describe: infra
sinedied commented 7 months ago

DO NOT merge for now, provisioning and deployment works fine, but there's now a CORS error. Something seems to be missing in the updated templates

sinedied commented 7 months ago

PR is now ready to merge, everything has been fully deployed and tested.

sinedied commented 6 months ago

@manekinekko I updated the PR to disabled public blob access in the main bicep file, should be good now