Closed amitkalay closed 1 month ago
Hey a meta comment about the organization of the work...
I think we shouldn't break things down this way. Instead of entityskill, imageskill and summary skill - I think we should have
AOAIInferenceSkill and CustomInferenceSkill
And each skill, should do all of the 3 things - with the backing models and client calls varying depending on if it's AOAI or the "Other" models.
@arv100kri - I understand the general organization of the work/code you had in mind for this a lot better now. Since this code still does something valuable for us (entity recognition), I will follow up in a future PR to refactor the codebase to do things to align with what was envisioned.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
Test Plan
I sent a POST request to the /api/entity_recognition endpoint and got the following output: