search

Azure-Samples / blockchain

Azure Blockchain Content and Samples
MIT License
822 stars 686 forks source link

Bug report in digital-locker smart contract #279

Open academic-starter opened 6 months ago

academic-starter commented 6 months ago

As documented by its following specification, Constructor funtion should finish with Requested state instead of DocumentReview.

https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.json#L31

  1. BeginReviewProcess function should begin with Requested state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L29

  2. UploadDocuments function should begin with DocumentReview state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L56

  3. ShareWithThirdParty should begin with AvailableToShare state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L68

  4. AcceptSharingRequest should begin with SharingRequestPending state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L84

  5. RejectSharingRequest should begin with SharingRequestPending state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L95

  6. RequestLockerAccess should begin with AvailableToShare state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L106

  7. ReleaseLockerAccess should begin with SharingWithThirdParty state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#118

  8. RevokeAccessFromThirdParty should begin with SharingWithThirdParty state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L132

  9. Terminate should begin with AvailableToShare|SharingRequestPending|SharingWithThirdParty state. https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.sol#L143

SimonGareis commented 6 months ago

Hello  Can you send the ethereum coins on this adresss 

0xFBb85E92d42e7f00bf03A299874fa4Db816B5F7C

Thanks Simon Gareis INB Philosophy LLC 

Gesendet von Yahoo Mail auf Android

Am Do., Feb. 22, 2024 at 8:30 schrieb @.***>:

As documented by its following specification, Constructor funtion should finish with Requested state instead of DocumentReview.

https://github.com/Azure-Samples/blockchain/blob/1b712d6d05cca8da17bdd1894de8c3d25905685d/blockchain-workbench/application-and-smart-contract-samples/digital-locker/ethereum/DigitalLocker.json#L31

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>