Azure-Samples / cdm-azure-data-services-integration

Tutorials and sample code for integrating CDM folders with Azure Data Services
MIT License
70 stars 46 forks source link

Prevent prompt to login again, if already logged in. Provide default … #2

Closed drwill-ms closed 5 years ago

drwill-ms commented 5 years ago

…parameters that will work for Azure Function deployment.

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce? !-- Please check the one that applies to this PR using "x". -->

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [drwill/AzureFuncArmProvision]

// Manually login Login-AzureRmAccount .\deploy.ps1 <with parameters including unique rg and -parametersFilePath ""> // Confirm not prompted to login again



## What to Check
Verify that the following are valid
* No errors during provision
* Resources appear in specified Azure subscription and resource group

## Other Information
The login check is standard code I've used before.

I thought it would be helpful, in case someone didn't edit/include the parameters.json file, that the deployment might work out of the box.