Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
787 stars 395 forks source link

fix: exception occurred deleting files #1110

Closed Prashant-Microsoft closed 2 months ago

Prashant-Microsoft commented 2 months ago

Purpose

Does this introduce a breaking change?

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

github-actions[bot] commented 2 months ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/search
   integrated_vectorization_search_handler.py73198%35
TOTAL263458877% 

Tests Skipped Failures Errors Time
292 0 :zzz: 0 :x: 0 :fire: 37.528s :stopwatch:
Prashant-Microsoft commented 2 months ago

Do we know under what circumstances this can happen? Do you have a copy or a screenshot of the error? Thanks

In some of the documents we are getting title field as null, that case it will give us error

image
adamdougal commented 2 months ago

Gotcha! My concern with this fix is that, yes it stops the exception, but it also stops the file being outputted, which means it cannot be deleted.

Could we address the issue of the title not being there instead?

Roopan-Microsoft commented 2 months ago

Gotcha! My concern with this fix is that, yes it stops the exception, but it also stops the file being outputted, which means it cannot be deleted.

Could we address the issue of the title not being there instead?

Yes @adamdougal - We are also trying the same scenario to repro that issue. Will figure it out

Prashant-Microsoft commented 2 months ago

Gotcha! My concern with this fix is that, yes it stops the exception, but it also stops the file being outputted, which means it cannot be deleted.

Could we address the issue of the title not being there instead?

@adamdougal Seems like this issue is intermittent, now we are not able to get the title field as null, everything working properly but still, we are working on it to repro the issue

adamdougal commented 2 months ago

Closing as we can't reproduce the error.