Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
787 stars 395 forks source link

fix: Remove time.sleep from test case #1127

Closed Pavan-Microsoft closed 2 months ago

Pavan-Microsoft commented 2 months ago

Purpose

The test_raises_exception_if_bad_response_code test in code/tests/utilities/helpers/test_azure_computer_vision_client.py fails intermittently. The use of time.sleep(0.3) in the previous test, test_vectorize_image_calls_computer_vision_timeout, is causing the issue. Therefore, we have updated the test case to remove time.sleep, ensuring that all tests now pass consistently.

Does this introduce a breaking change?

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
github-actions[bot] commented 2 months ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL263358877% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
292 0 :zzz: 0 :x: 0 :fire: 40.778s :stopwatch:
github-actions[bot] commented 2 months ago

:tada: This PR is included in version 1.9.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: