Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
839 stars 433 forks source link

fix: Fixed Admin Interface: Explore Data-Files visibility issue #1128

Closed Prasanjeet-Microsoft closed 4 months ago

Prasanjeet-Microsoft commented 4 months ago

Purpose

Fixed files visibility issue under explore data section in Admin interface where end user was not able to see more than 10 files and after this code fix we are able to see all the files.

Does this introduce a breaking change?

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Upload more than 10 files from ingest data section in admin interface and verify that we are able to see all the files in explore data section. Please find below screenshots for your reference.

image

image

github-actions[bot] commented 4 months ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/search
   search_handler_base.py49981%33, 39, 43, 47, 51, 55, 59, 63, 67
code/backend/pages
   02_Explore_Data.py28280%1–7, 9–10, 12, 20, 28, 31–33, 37, 40–41, 43–46, 48–51, 54–55
TOTAL264458277% 

Tests Skipped Failures Errors Time
298 0 :zzz: 0 :x: 0 :fire: 40.470s :stopwatch:
Prasanjeet-Microsoft commented 4 months ago

Do we know why this caused the bug in the first place? Thanks

Because in the admin interface under explore data section, we were not able to see more than 10 files earlier.

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 1.9.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: