Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
787 stars 395 forks source link

fix: AZURE_SEARCH_TOP_K and AZURE_OPENAI_SYSTEM_MESSAGE keeps reseting after running azd env set and azd up command #1146

Closed Prasanjeet-Microsoft closed 2 months ago

Prasanjeet-Microsoft commented 2 months ago

Purpose

Added azureOpenAISystemMessage and azureSearchTopK param in main.bicepparam file to set the value of AZURE_SEARCH_TOP_K and AZURE_OPENAI_SYSTEM_MESSAGE env variable in azure using azd env set and azd up command

Does this introduce a breaking change?

How to Test

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Run below commands from VS code powershell terminal:

azd env set AZURE_SEARCH_TOP_K 15 azd up azd env refresh

And check whether value of AZURE_SEARCH_TOP_K is getting updated in azure and local both. And the value should not get reset to 5 in .env file in your local.

Please find below screenshot for your reference:

image
github-actions[bot] commented 2 months ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL264558377% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
298 0 :zzz: 0 :x: 0 :fire: 38.871s :stopwatch:
github-actions[bot] commented 2 months ago

:tada: This PR is included in version 1.9.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: