fix: The issue of ambiguous language reply solved

Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.

https://azure.microsoft.com/products/search

MIT License

839 stars 433 forks source link

fix: The issue of ambiguous language reply solved #1149

Closed Harmanpreet-Microsoft closed 3 months ago

Harmanpreet-Microsoft commented 4 months ago

Purpose

To resolve the bug for language ambiguity when said Hi to the bot the reply is in spanish

Does this introduce a breaking change?

[x] Yes
[ ] No

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

What to Check

Verify that the following are valid When bot is communicated in particular language it replies in the language itself

github-actions[bot] commented 4 months ago

Coverage Report •

File	Stmts	Miss	Cover	Missing
code/backend/batch/utilities/orchestrator
open_ai_functions.py	54	11	79%	111–113, 116, 119–120, 123, 128–130, 135
semantic_kernel.py	54	0	100%
TOTAL	2645	583	77%

Tests	Skipped	Failures	Errors	Time
298	0 :zzz:	0 :x:	0 :fire:	38.161s :stopwatch:

adamdougal commented 3 months ago

@Harmanpreet-Microsoft please see https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/pull/1149#issuecomment-2235692030. It needs addressing before this PR can be approved and merged. Thanks

Harmanpreet-Microsoft commented 3 months ago

@microsoft-github-policy-service agree company="Microsoft"

Harmanpreet-Microsoft commented 3 months ago

Hi @adamdougal I have completed the needful task

github-actions[bot] commented 3 months ago

:tada: This PR is included in version 1.9.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: