Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
839 stars 433 forks source link

fix: Configuration tab "Reset configuration to Defaults" confuses the user whether it is button or dropdown. #1196

Closed Rohini-Microsoft closed 3 months ago

Rohini-Microsoft commented 3 months ago

Purpose

Configuration tab "Reset configuration to Defaults" confuses the user whether it is button or dropdown. and adding x button for close the popup

Does this introduce a breaking change?

git clone [repo-address] cd [repo-name] git checkout [branch-name] npm install

What to Check

  1. go to the Admin page, Scroll down under "Configuration" section
  2. Click on "Reset to default configuration" tab
  3. the up arrow indicates the tab as dropdown, but it pops up this window.
  4. It creates confusion whether it is dropdown or button.

image

github-actions[bot] commented 3 months ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/pages
   04_Configuration.py1541540%1–10, 12–13, 15, 23–25, 29, 31, 36–45, 48–49, 52–63, 65–68, 70–72, 76–77, 89–93, 96–99, 103–104, 109–110, 114–116, 119–120, 123–124, 127–128, 151, 153–154, 156–160, 162–165, 168–172, 179–180, 190–194, 214–219, 226, 228, 233, 241, 249, 256–257, 264, 266–267, 271, 279, 285, 292, 310–314, 320–321, 340–341, 345, 347–348, 371, 406–407, 411, 414–416, 418, 422–423, 426–429, 431–432, 434–436, 438–441, 443–444
TOTAL264858677% 

Tests Skipped Failures Errors Time
298 0 :zzz: 0 :x: 0 :fire: 39.224s :stopwatch:
github-actions[bot] commented 3 months ago

:tada: This PR is included in version 1.9.7 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: