Always destroy - Githubissues

Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.

https://azure.microsoft.com/products/search

MIT License

624 stars 294 forks source link

Always destroy #556

Closed ross-p-smith closed 2 months ago

ross-p-smith commented 2 months ago

Purpose

We should always destroy what we just built

Does this introduce a breaking change?

[ ] Yes
[x] No

How to Test

Does it destroy the environment

github-actions[bot] commented 2 months ago

Coverage Report •

File	Stmts	Miss	Cover	Missing
TOTAL	1637	980	40%

report-only-changed-files is enabled. No files were changed during this commit :)

Tests	Skipped	Failures	Errors	Time
40	0 :zzz:	0 :x:	0 :fire:	10.454s :stopwatch:

superhindupur commented 2 months ago

I was doing the same thing today after the discussion this morning. But I see you’ve created the pr already. I was trialing this along with the ui tests on my branch today.

ross-p-smith commented 2 months ago

I was doing the same thing today after the discussion this morning. But I see you’ve created the pr already. I was trialing this along with the ui tests on my branch today.

Oh really sorry! That's 2 people I've done that too today! :-( Sorry

superhindupur commented 2 months ago

Can you add a link to the passing build from before you merged this, so we have a record of testing this before we merged it?

ross-p-smith commented 2 months ago

https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator/actions/runs/8457495014/job/23169582713