Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
522 stars 274 forks source link

Add Semantic Kernel as orchestrator #787

Closed cecheta closed 2 weeks ago

cecheta commented 2 weeks ago

Closes #758

Purpose

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

What to Check

Verify that the following are valid

github-actions[bot] commented 2 weeks ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch/utilities/helpers
   ConfigHelper.py1120100% 
   LLMHelper.py401172%40–41, 50, 61–62, 73, 86–87, 94, 104, 112
code/backend/batch/utilities/orchestrator
   LangChainAgent.py601968%21–24, 26, 61–62, 82–85, 102–103, 106–109, 116–117
   OpenAIFunctions.py54540%1–3, 5–10, 12, 15–18, 53, 57–59, 62, 64, 70–73, 75, 78, 85–89, 93–94, 96, 102–106, 110–112, 115, 118–119, 122, 127–129, 132–134, 137, 142
   OrchestratorBase.py52884%35, 74–76, 83–85, 95
   SemanticKernel.py520100% 
   Strategies.py161037%11–12, 14–16, 18–20, 22, 24
code/backend/batch/utilities/parser
   OutputParserTool.py390100% 
code/backend/batch/utilities/plugins
   ChatPlugin.py150100% 
   PostAnsweringPlugin.py80100% 
code/backend/batch/utilities/tools
   AnsweringToolBase.py9277%9, 15
   PostPromptTool.py221340%11, 14–15, 17–18, 22, 29, 36–37, 45, 51–52, 60
   QuestionAnswerTool.py620100% 
   TextProcessingTool.py16943%9, 12–15, 21, 23, 30, 37
TOTAL221376365% 

Tests Skipped Failures Errors Time
163 0 :zzz: 0 :x: 0 :fire: 10.381s :stopwatch:
ross-p-smith commented 2 weeks ago

really happy with the direction - going to deploy and have a play! Let me know if you want me to involve the SK team

ross-p-smith commented 2 weeks ago

nit: When I chose semantic_kernel in the Configuration page, it succesfully saves the config in storage, but the UI (drop down) does not show that I am on semantic kernel

ross-p-smith commented 2 weeks ago

Accidentally closed this - sorry!