Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
522 stars 274 forks source link

Simplify BatchStartProcessing function method. #789

Closed superhindupur closed 2 weeks ago

superhindupur commented 2 weeks ago

Purpose

The BatchStartProcessing function API was only ever being called with process_all=true, so I simplified it. This reduced further code from the Ingest page in the Admin app.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Deploy the admin web, the function app and test whether "Reprocess all documents..." button works.

github-actions[bot] commented 2 weeks ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
code/backend/batch
   BatchStartProcessing.py180100% 
code/backend/pages
   01_Ingest_Data.py1181180%1–12, 18–22, 24–26, 28, 34, 41, 44, 48–49, 51, 56, 59–60, 63–66, 68–71, 75–77, 80–83, 85, 88–98, 101–108, 111–113, 115, 118, 120–123, 128–133, 136, 139–140, 143, 149, 162–165, 168–169, 173, 177, 184, 198–201, 204, 209–210, 212–213, 215–217, 221–223, 228–231, 238–239, 244, 246–247
TOTAL210383560% 

Tests Skipped Failures Errors Time
129 0 :zzz: 0 :x: 0 :fire: 7.604s :stopwatch: