search

Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
521 stars 274 forks source link

Add missing storage permission #797

Closed cecheta closed 2 weeks ago

cecheta commented 2 weeks ago

Closes #643

Purpose

This used to fail silently when attempting to fetch the config fron Storage, falling back to the default config , but following #706 it now fails with an error.

Change was originally included in #787, but moving to separate PR as #787 may stay open for a long time.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

What to Check

Verify that the following are valid

github-actions[bot] commented 2 weeks ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL213180062% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
143 0 :zzz: 0 :x: 0 :fire: 7.736s :stopwatch: