feat: Use openai client for Azure BYOD

Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.

https://azure.microsoft.com/products/search

MIT License

624 stars 294 forks source link

feat: Use openai client for Azure BYOD #831

Closed cecheta closed 3 weeks ago

cecheta commented 3 weeks ago

Closes #602, required for #295

Purpose

This PR updates the byod endpoint to use the openai package when calling Azure OpenAI, rather than making a HTTP request with requests. This matches official documentation
Adds (unrelated) tests to not drop coverage

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Deploy code
Change frontend code to use BYOD endpoint
Chat

What to Check

Response received
- With/without streaming
- RBAC/keys

github-actions[bot] commented 3 weeks ago

Coverage Report •

File	Stmts	Miss	Cover	Missing
code
create_app.py	130	3	97%	190, 195, 313
TOTAL	2252	696	69%

Tests	Skipped	Failures	Errors	Time
166	0 :zzz:	0 :x:	0 :fire:	11.078s :stopwatch:

ross-p-smith commented 3 weeks ago

Based on your description, I agree - why would we just front GPT - this is meant to be about Search. @ruoccofabrizio and @gmndrg - can you confirm you are Ok with this principle please?

gmndrg commented 3 weeks ago

@ross-p-smith this is an AI Search accelerator, correct, so it is to use this specific product and how to. Thank you!

ruoccofabrizio commented 3 weeks ago

This is part of the effort to keep a single front end for multiple backend:

Standard GPT
Chat with your own data
Custom Backend I won't remove it as it's used by customers and removing it doesn't add any value.

cecheta commented 3 weeks ago

This is part of the effort to keep a single front end for multiple backend:

Standard GPT

Chat with your own data

Custom Backend I won't remove it as it's used by customers and removing it doesn't add any value.

Thanks for the input @ruoccofabrizio,

I would have thought that if users were looking for a standard GPT they would use https://github.com/microsoft/sample-app-aoai-chatGPT, however if customers are currently using it then I will add it back

cecheta commented 3 weeks ago

"Without data" re-introduced