search

Azure-Samples / chat-with-your-data-solution-accelerator

A Solution Accelerator for the RAG pattern running in Azure, using Azure AI Search for retrieval and Azure OpenAI large language models to power ChatGPT-style and Q&A experiences. This includes most common requirements and best practices.
https://azure.microsoft.com/products/search
MIT License
624 stars 294 forks source link

build: Adding params that we have ENV for #868

Closed ross-p-smith closed 2 weeks ago

ross-p-smith commented 3 weeks ago

Purpose

Relates to #796

This is a part fix for #796 as we need to design this so that it works for people who use azd, plain bicep and the "Deploy to Azure" button. Not all environment variables have a corresponding input bicep param as they are outputs of the bicep. I'm also unsure how brittle we will make this if we allow people change the name of Azure resources through the environment variables, I think it was better if they were bicepparam's and the ENV values were the output. I will look into this next.

This PR just adds those values that are ENV and params so that you can deploy using azd up and then update using azd env set KEY VALUE and then azd up again and have the deployment respect the value you have just set.

This also has a small tweak to the B3 -> B1 issue

github-actions[bot] commented 3 weeks ago

Coverage

Coverage Report •
FileStmtsMissCoverMissing
TOTAL227766770% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
173 0 :zzz: 0 :x: 0 :fire: 11.924s :stopwatch:
gaurarpit commented 3 weeks ago

Should we create a User Story/task for this ?

I'm also unsure how brittle we will make this if we allow people change the name of Azure resources through the environment variables, I think it was better if they were bicepparam's and the ENV values were the output. I will look into this next.