Closed liammoat closed 1 month ago
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
201 | 0 :zzz: | 0 :x: | 0 :fire: | 12.926s :stopwatch: |
Team - Couple of things to note about this PR:
Team - Couple of things to note about this PR:
- There is likely a better way to do this - however, I have tried to implement it with as few downstream changes as possible (i.e. I don't want to refactor everything to fix this)
- With this change in mind, I propose the admin app should delete the blob, and let the function handle the index.
- I will leave this in draft until I have introduce some tests to cover the core behaviour
Definitely agree with " I propose the admin app should delete the blob, and let the function handle the index." - could you please create an issue to cover this if there isn't one already?
Update: I see that @komalg1 is working on this in #876 - would be worth the two of you catching up.
@liammoat thanks so much for this, really appreciate it! ❤️
Purpose
batch_push_results
receives, but does not handle, blob delete events.Does this introduce a breaking change?
How to Test
#1
Create a blob, uploading via Azure Storage#2
Delete the blob from Azure Storage#3
Trigger `BatchStartProcessing functionWhat to Check
Verify that the following are valid
#1
BatchPushResults
is triggered, and the document is indexed.#2
BatchPushResults
is triggered, and the associated indexes are removed.#3
BatchPushResults
is triggered, as normal, and the documents are indexed.Other Information
Remaining Actions
The following is outstanding for this PR: